Dynamic page #4
Merged
Dynamic page #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dynamic-page-petya
…SAP#7845) * feat(ui5-dynamic-page): ensure visibility of title content that never overflows * feat(ui5-dynamic-page) actions style corrected Co-authored-by: Dobrin Dimchev <[email protected]> * feat(ui5-dynamic-page): sizing of toolbar wrappers corrected * feat(ui5-dynamic-page): apply review feedback --------- Co-authored-by: Dobrin Dimchev <[email protected]>
…dynamic-page-petya
…#7904) * feat(ui5-dynamic-page): prevent unnecessary content overflow when footer hidden * feat(ui5-dynamic-page): move scroll listener to the new scroll container
* feat(ui5-dynamic-page): fit content that has 100% height * feat(ui5-dynamic-page): correct import * feat(ui5-dynamic-page): add tests
* feat(ui5-dynamic-page): keyboard handling * feat(ui5-dynamic-page): add focus span * fix: add expand and focus on title click --------- Co-authored-by: Dobrin Dimchev <[email protected]>
fix(ui5-dynamic-page): apply theme styles Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
* feat(ui5-dynamic-page): screen reader support * feat(ui5-dynamic-page): add tests
fix(ui5-dynamic-page): story and docs added Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Co-authored-by: PetyaMarkovaBogdanova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 👏
PR checklist
For example:
fix(ui5-*): correct/fix sthorfeat(ui5-*): add/introduce sth. If you don't want the change to be part of the release changelog - usechore,refactorordocs.Add proper description about the background of the change and the change itself
Link to an existing issue (if available)
Use
Fixes: {#PR_NUMBER}to close the issue automatically when the PR is mergedor
Related to: {#PR_NUMBER}to just create a link between the PR and the issue.